search

shaka-project / shaka-packager

A media packaging and development framework for VOD and Live DASH and HLS applications, supporting Common Encryption for Widevine and other DRM Systems.
https://shaka-project.github.io/shaka-packager/
Other
2.01k stars 512 forks source link

fix: Fix NPM binary publication #1371

Closed joeyparrish closed 8 months ago

joeyparrish commented 8 months ago

The default .npmignore would disallow bin/, which contains binaries for our NPM release. Every release before v3.0.3 was missing .npmignore, and therefore had no binaries. These were unusable in NPM, and have been marked as deprecated because of it.

Closes #1369

joeyparrish commented 8 months ago

I verified this manually through npm pack. Final verification will be through the job https://github.com/joeyparrish/shaka-packager/actions/runs/8254276102, which will publish to https://www.npmjs.com/package/@joeyparrish/shaka-packager-staging

joeyparrish commented 8 months ago

Now verified through the full publication process.