fix: Break header installation for the shared library

[zaki699]

include/file.h is breaking header installation for the shared library build. macros/classes.h must be included to the public headers.

Closes #1406

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[joeyparrish]

I started the tests for this... why did you close it?

[zaki699]

Hi Joey,

Sorry I made a wrong manip. I reopened it.

Zaki

On May 30, 2024, at 10:31 PM, Joey Parrish @.***> wrote:

I started the tests for this... why did you close it?

— Reply to this email directly, view it on GitHubhttps://github.com/shaka-project/shaka-packager/pull/1407#issuecomment-2140816762, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR4JL6YBTG7ORU4K6KWWI5DZE6ECDAVCNFSM6AAAAABIRR3JOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQHAYTMNZWGI. You are receiving this because you modified the open/close state.Message ID: @.***>

[joeyparrish]

I edited your PR and added the necessary line (file.h) to packager.h to make sure the packager_link_test target can catch macros/classes.h being missing.

[zaki699]

Thx for your help. Very appreciated.

Get Outlook for iOShttps://aka.ms/o0ukef

---

From: Joey Parrish @.> Sent: Thursday, May 30, 2024 10:45:16 PM To: shaka-project/shaka-packager @.> Cc: zaki699 @.>; State change @.> Subject: Re: [shaka-project/shaka-packager] fix: Break header installation for the shared library (PR #1407)

I edited your PR and added the necessary line (file.h) to packager.h to make sure the packager_link_test target can catch macros/classes.h being missing.

— Reply to this email directly, view it on GitHubhttps://github.com/shaka-project/shaka-packager/pull/1407#issuecomment-2140835880, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR4JL64O6O4SZANFAMX3P23ZE6FVZAVCNFSM6AAAAABIRR3JOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQHAZTKOBYGA. You are receiving this because you modified the open/close state.Message ID: @.***>

[joeyparrish]

Happy to help. That check really should have caught this, and I created it, so it was the least I could do.

[zaki699]

I think the CLA is not working because my git configuration was not setting up correctly and was using the wrong email and user.

Do you mind telling me what to do to fix this ?

Get Outlook for iOShttps://aka.ms/o0ukef

---

From: Joey Parrish @.> Sent: Thursday, May 30, 2024 10:53:06 PM To: shaka-project/shaka-packager @.> Cc: zaki699 @.>; State change @.> Subject: Re: [shaka-project/shaka-packager] fix: Break header installation for the shared library (PR #1407)

Happy to help. That check really should have caught this, and I created it, so it was the least I could do.

— Reply to this email directly, view it on GitHubhttps://github.com/shaka-project/shaka-packager/pull/1407#issuecomment-2140846949, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR4JL65B4ONLTFALU43SJXDZE6GTFAVCNFSM6AAAAABIRR3JOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQHA2DMOJUHE. You are receiving this because you modified the open/close state.Message ID: @.***>

[joeyparrish]

Sure. I'm going to the "Details" link next to the CLA check at the bottom of the PR. There, I see a list of the contributors from the git commits:

The following contributors were found for this pull request:

✅ https://github.com/shaka-project/shaka-packager/commit/1ef5981e3bb0b84421ee893dd1878391ec93f0ad PR Opener: @zaki699 ❌ https://github.com/shaka-project/shaka-packager/commit/6fb1ad653dbd1f822bf63c8e1a5bbbef475d6df3 Author: o***n​@Zakis-MacBook-Pro.local ✅ https://github.com/shaka-project/shaka-packager/commit/1ef5981e3bb0b84421ee893dd1878391ec93f0ad Author: @joeyparrish joeyparrish​@users.noreply.github.com

So it's the commit from ...​@Zakis-MacBook-Pro.local that doesn't match the CLA. You just need to run git config to set your name and email address, then amend the commit in question and force-push the PR branch.

[zaki699]

Ok Now the CLA is validated.

Thx

[zaki699]

It seems that I have somehow managed to remove your previous commit. Do you mind pushing it again ?

Thanks you

[joeyparrish]

Done

[joeyparrish]

I will merge this if the tests pass, which I fully expect