search

shaka-project / shaka-packager

A media packaging and development framework for VOD and Live DASH and HLS applications, supporting Common Encryption for Widevine and other DRM Systems.
https://shaka-project.github.io/shaka-packager/
Other
1.97k stars 507 forks source link

Support for AC-4 audio on packager #705

Closed yotta-stu closed 4 years ago

yotta-stu commented 4 years ago

System info

Operating System: <e.g. macOS Sierra, Ubuntu 14.04 trusty etc> Ubuntu 16.04.5 Shaka Packager Version: <e.g. v1.6.1, commit SHA etc> version 53aa775-release

Issue and steps to reproduce the problem

Request support for Dolby AC-4 audio type. Packager Command: sudo ./packager \ 'input=/home/packager/content/'$content',stream=video,init_segment='$out'/video/init-video.mp4,segment_template='$out'/video/$Number$.m4s' \ 'input=/home/packager/content/'$content',stream=1,init_segment='$out'/audio/init-audio.mp4,segment_template='$out'/audio/$Number$.m4s' \ --segment_duration 1 \ --generate_static_mpd \ --allow_approximate_segment_timeline \ --segment_template_constant_duration \ --mpd_output $out/manifest.mpd

Extra steps to reproduce the problem? (1) Run with MP4 content that contains AC-4 audio. (2)

What is the expected result? Would like support for the AC-4 audio type so it is packaged along with video. What happens instead? Error with unsupported audio format, see error log:

[0130/110559:WARNING:mp4_media_parser.cc(454)] Unsupported audio format 'ac-4' in stsd box. [0130/110559:ERROR:audio_stream_info.cc(129)] Not implemented reached in static std::string shaka::media::AudioStreamInfo::GetCodecS tring(shaka::media::Codec, uint8_t)Codec: 0 [0130/110559:ERROR:mp4_muxer.cc(480)] Not implemented reached in bool shaka::media::mp4::MP4Muxer::GenerateAudioTrak(const shaka::me dia::AudioStreamInfo , shaka::media::mp4::Track , uint32_t) Unsupported audio codec 0 [0130/110559:ERROR:demuxer.cc(319)] Failed to process sample 1 11 (MUXER_FAILURE): Failed to generate trak. [0130/110559:ERROR:mp4_media_parser.cc(790)] Failed to process the sample. [0130/110559:ERROR:packager_main.cc(518)] Packaging Error: 8 (PARSER_FAILURE): Cannot parse media file <Please attach the input files or email to shaka-packager-issues@google.com.> via email.

kqyang commented 4 years ago

@yotta-stu Do you have a sample AC-4 we can use for development?

yotta-stu commented 4 years ago

You can download the content with AC-4 from this link (it will be active for 7 days)

https://we.tl/t-7PtB6FcK9O

Thanks,

Stuart

From: Kongqun Yang notifications@github.com Sent: 30 January 2020 18:34 To: google/shaka-packager shaka-packager@noreply.github.com Cc: yotta-stu stuart.ballinger@yottamedialabs.com; Mention mention@noreply.github.com Subject: Re: [google/shaka-packager] Support for AC-4 audio on packager (#705)

@yotta-stu https://github.com/yotta-stu Do you have a sample AC-4 we can use for development?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/google/shaka-packager/issues/705?email_source=notifications&email_token=AMD3OK2JLII6HOUDTIP4MITRAMMR7A5CNFSM4KNUWTYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKMBIIA#issuecomment-580391968 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AMD3OK2QUQVT5CNZMR2KXG3RAMMR7ANCNFSM4KNUWTYA . https://github.com/notifications/beacon/AMD3OK27JZCSAYQTTCG5PDDRAMMR7A5CNFSM4KNUWTYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKMBIIA.gif

kqyang commented 4 years ago

@yotta-stu Thanks!

kqyang commented 4 years ago

This is a duplicate of #754.