search

shaka-project / shaka-player-embedded

Shaka Player in a C++ Framework
Apache License 2.0
236 stars 63 forks source link

Build fails when using EME #131

Closed okycelt closed 4 years ago

okycelt commented 4 years ago

The build fails when using a8acedfa8152e341d97a2d3829c182b3e80c407a of shaka-player-embedded and f05ddc6 of prebuilt_cdm (both the latest master at the moment) with the following error:

[855/1180] CXX obj/eme_plugins/widevine_implementation_factory.o
FAILED: obj/eme_plugins/widevine_implementation_factory.o 
..
7 warnings and 2 errors generated.
[857/1180] CXX obj/eme_plugins/widevine_implementation.o
FAILED: obj/eme_plugins/widevine_implementation.o 
..
10 warnings generated.
ninja: build stopped: subcommand failed.

The whole log here: spe_build_error.txt

Configuration command:

../configure --ios --cpu arm64 --eme-impl ~/XcodeProjects/prebuilt_cdm/shaka_plugin/dev_cdm.json

Could it be related to 4277ec99a64ee2bd27db15b3d36c5dee733c34ee? The commit message says the EME interface changed, but there was no update at the prebuilt_cdm repository since February. Also, 3cbc8c1ea58877b20a3016407ebfaecc5bfaf524 (which is two commits before 4277ec99a64ee2bd27db15b3d36c5dee733c34ee) builds okay.

macOS 10.15.4 Xcode 11.4

TheModMaker commented 4 years ago

Whoops, I made this fix internally, but I think I forgot to push to the partner repo.

TheModMaker commented 4 years ago

I just pushed the changes to the partner repo. So it should work if you pull the latest prebuilt_cdm.