Build fails when using EME

okycelt commented 4 years ago

The build fails when using b9ddc533754fb33b4043cac1734730313ce74c7c or newer of shaka-player-embedded and 28c44ac of prebuilt_cdm (latest master) with the following error:

...
In file included from ../shaka/src/mapping/backing_object.h:23:
../shaka/src/mapping/weak_js_ptr.h:114:34: warning: unused parameter 'tracer' [-Wunused-parameter]
  void Trace(memory::HeapTracer* tracer) const override {
                                 ^
../prebuilt_cdm/shaka_plugin/cdm_host.cc:31:7: error: use of undeclared identifier 'PlainCallbackTask'
      PlainCallbackTask(std::bind(&IClient::onTimerExpired, client, context)));
      ^
In file included from ../prebuilt_cdm/shaka_plugin/cdm_host.cc:3:
In file included from ../prebuilt_cdm/shaka_plugin/cdm_host.h:11:
...
10 warnings and 1 error generated.
[728/1042] CXX obj/internal_sources/environment.o
ninja: build stopped: subcommand failed.

Build without EME seems okay
The whole log here: spe_build_error.txt

Configuration command:

../configure --ios --cpu arm64 --eme-impl ~/XcodeProjects/prebuilt_cdm/shaka_plugin/dev_cdm.json

macOS 10.15.4 Xcode 11.4.1

TheModMaker commented 4 years ago

I really need to include EME in our pre-submit checks. I forgot to update the CDM plugin with some recent changes.

TheModMaker commented 4 years ago

I just pushed a fix to the prebuilt_cdm repo. Also, I've updated our pre-submit checks so hopefully I won't break EME plugins again.

shaka-project / shaka-player-embedded

Build fails when using EME #138