search

shaka-project / shaka-player-embedded

Shaka Player in a C++ Framework
Apache License 2.0
236 stars 63 forks source link

Ad support #140

Open okycelt opened 4 years ago

okycelt commented 4 years ago

Since v3.0.0, Shaka Player contains a Google IMA SDK integration. We're already using it in our web player and it seems pretty good. Would it be possible to support this in Shaka Player Embedded as well? We would benefit from this greatly.

Thanks in advance

TheModMaker commented 4 years ago

We can definitely look into adding something, but it will probably just be exposing ad info for the app to handle.

There are a lot of ad providers out there, so it would be a lot of work to add integration with all of them. Also, we currently don't provide a UI for the project and the problem of how to handle configuring the UI is one of the main reasons we don't. So it will probably be the app's job to display the ads anyway.

What would probably happen is we would provide events or data for where the ads are and the app would hook that up with their favorite ad manager. For server-side ads, we could add fetching the manifest and also expose when we're in an ad so the app's UI can change for the ad.