search

shaka-project / shaka-player-embedded

Shaka Player in a C++ Framework
Apache License 2.0
236 stars 63 forks source link

Option to reposition the subtitles #142

Open sebicoo opened 4 years ago

sebicoo commented 4 years ago

We have an issue with the position of the subtitles, we want to offer to our users the option to do an aspect-fill in landscape mode, but for iphones like iPhone X, XS, XR, 11 this option would push the subtitles off-screen. We have this issue only with dash content - subtitle is aligned to the bottom of the screen. Other types of content have the subtitle rendered higher. To achieve this zoom, we use constraints similar to those in the sample_xcode_project. Is there an option to set the height? If not, is there a way to set a default height for rendering the subtitles before building the SDK?

HLS: vod_subtitle_angelone_hls

DASH: vod_subtitle_angelone_dash

TheModMaker commented 4 years ago

If you want to change the video fill mode, you should use setVideoGravity on ShakaPlayerView. Changing the constraints on the view will not change the aspect ratio, the video will always maintain ratio and black bars will be inserted to achieve this. To change this, you need to change the video gravity.

As for the height, there is no such option. I think it would be better for us to just move the captions above to match the native HLS instead of requiring the app to configure it.