shaka-project / shaka-player-embedded

Shaka Player in a C++ Framework
Apache License 2.0
238 stars 63 forks source link

Missing setTextTrackVisibility #172

Closed kareljuricka closed 3 years ago

kareljuricka commented 3 years ago

I missing setTextTrackVisibility(..) inside ShakaPlayer (https://google.github.io/shaka-player-embedded/interfaceShakaPlayer.html).

I found setTextTrackVisibility only in Player api (https://google.github.io/shaka-player-embedded/classshaka_1_1Player.html), but I can't find away to access Player object from ShakaPlayer or ShakaPlayerView or somehow..

I hope I just miss something. Thanks for advice.

TheModMaker commented 3 years ago

This is changed using the closedCaptions property on ShakaPlayer. Some of the getter functions were changed to properties to be more consistent with programming styles in native code.

kareljuricka commented 3 years ago

I see and can confirm that this solution works! Thanks