Fix XMLHttpRequest withCredentials not being writable

shaka-project / shaka-player-embedded

Shaka Player in a C++ Framework

Apache License 2.0

239 stars 62 forks source link

Fix XMLHttpRequest withCredentials not being writable #69

Closed nitro404 closed 4 years ago

nitro404 commented 4 years ago

Add DOMException if value is set while XHR is in incorrect state
Fix withCredentials value being reset when it shouldn't be

nitro404 commented 4 years ago

Yep, that's exactly the reasoning here. Even if it is not supported, I don't think it makes sense to violate the DOM specification and make this value read-only. If you would prefer to leave this as is, I understand!