There is no reference to the ShakaPlayerView firing the events received by the client. This forces the user of the library to either store a shared variable pointing to the player (if the client is implemented in the same class which creates the player) or create the client providing the player as a parameter of the constructor (if extracting the client functionality elsewhere).
It is common practice of the delegate pattern in the iOS SDK to provide the object firing the event as a parameter to the delegate method being invoked to avoid this (some examples: UIScrollViewDelegate, UICollectionViewDelegate...)
Can you please add the ShakaPlayerView firing the event as a parameter to every method of ShakaPlayerClient?
There is no reference to the ShakaPlayerView firing the events received by the client. This forces the user of the library to either store a shared variable pointing to the player (if the client is implemented in the same class which creates the player) or create the client providing the player as a parameter of the constructor (if extracting the client functionality elsewhere).
It is common practice of the delegate pattern in the iOS SDK to provide the object firing the event as a parameter to the delegate method being invoked to avoid this (some examples: UIScrollViewDelegate, UICollectionViewDelegate...)
Can you please add the ShakaPlayerView firing the event as a parameter to every method of ShakaPlayerClient?