shaka-project / shaka-player

JavaScript player library / DASH & HLS client / MSE-EME player
Apache License 2.0
7.2k stars 1.34k forks source link

Integrate with non-linear IMA CS ads #2596

Closed jakubvojacek closed 3 years ago

jakubvojacek commented 4 years ago

Have you read the FAQ and checked for duplicate open issues? yes

What version of Shaka Player are you using? nigthly master demo

Can you reproduce the issue with our latest release version? yes

Can you reproduce the issue with the latest code from master? yes

Are you using the demo app or your own custom app? your nightly demo

If custom app, can you reproduce the issue using our demo app? yes

What browser and OS are you using? MacOS + Chrome

What are the manifest and license server URIs? Big bunny video from your demo + IMA SDK sample tag from page https://developers.google.com/interactive-media-ads/docs/sdks/html5/tags called Single Non-linear Inline (I believe those links expire after some time so Im not sharing link directly to the VMAP)

What did you do? Attempted to play the custom clear dash content with given ad url

What did you expect to happen? that the non linear image would be displayed and the video would start in the background

What actually happened? the ad was displayed but the video never started (and the controls are hidden behind the banner)

ismena commented 4 years ago

Hi @jakubvojacek Thanks for the report! We are only launching linear ads with our upcoming release, so I'm converting this issue to a feature request.

I will prioritize this work now that I know that real people are using this functionality! If there are any other ad types/requests that are a priority to you, please feel free to also let us know, we will schedule accordingly.

jakubvojacek commented 4 years ago

Thank you @ismena. We're planning to launch with linear, nonlinear and surveys (already discussed in another issue), targeted platforms are android (exoplayer), web and ios (via shaka player embedded).

So far we're havent found any issues with linear ads but were just in the process of creating our ad manager and creating our own vmap xmls. In case we run into more issues, I will open a ticket

Once again thank you