search

shaka-project / shaka-player

JavaScript player library / DASH & HLS client / MSE-EME player
Apache License 2.0
6.94k stars 1.32k forks source link

Support alignment in CEA-608 #2940

Open avelad opened 3 years ago

avelad commented 3 years ago

According to https://github.com/google/shaka-player/pull/2731, positioning and alignment not supported.

This issue is to track additional support for this functionality.

Note: DASH-IF seems to have support for this functionality.

TheModMaker commented 3 years ago

Do you have any sample content that uses positioning?

avelad commented 3 years ago

@TheModMaker the streams of https://github.com/google/shaka-player/pull/2939 have positioning

caridley commented 2 years ago

We need this as well, to prevent captions from covering important content like scores in sports programming.

caridley commented 2 years ago

This is a high priority for us, and we can help with implementation. We can provide access to streams for development purposes, but won't be able to provide long term access to those streams for use in regression testing or demo content.

It would be much appreciated if a Shaka developer with some expertise in the Shaka caption code could sketch out how this might be done in a way that is consistent with the existing architecture. Is this issue the appropriate place for that discussion?

iskewedI commented 1 year ago

Hi @avelad could you give me the status for this issue? I was about to open a new issue regarding CEA-608 captions that aren't being positioned correctly in the screen for TizenTV, and just found this. For the client the CC alignment is really important, so we need to confirm if you are going to support it. Thank you!

avelad commented 1 year ago

The issue is still open, so we haven't worked on it yet. If you are interested in doing a PR for it, let us know. Thank you!

avelad commented 10 months ago

I added support to vertical position in https://github.com/shaka-project/shaka-player/issues/2940