search

shaka-project / shaka-player

JavaScript player library / DASH & HLS client / MSE-EME player
Apache License 2.0
7.13k stars 1.33k forks source link

Support for getAllThumbnails API with multi period manifest #6461

Closed burugupalli closed 6 months ago

burugupalli commented 6 months ago

Have you read the FAQ and checked for duplicate open issues? Yes

Is your feature request related to a problem? Please describe.

Yes, current implementation of getAllThumbnails API is returning thumb nails for manifest with only one period. If the manifest has multiple periods, API doesn't return anything.

Describe the solution you'd like

getAllThumbnails API should work and return the thumbnails for any type of manifest

Describe alternatives you've considered

Additional context

avelad commented 6 months ago

@burugupalli Please provide a sample stream in order to implement this. Thanks!

avelad commented 6 months ago

I can work on it soon if the stream is provided

burugupalli commented 6 months ago

@avelad Do you still need a stream?

avelad commented 6 months ago

@avelad Do you still need a stream?

I have tried another, if you give me yours I will verify that the fix works well with yours.

burugupalli commented 6 months ago

@avelad Below is the stream.

https://content-ausw1.uplynk.com/preplay2/a896433ad8a24eab98bd13b764935775/527714cb231e6d33e14c57546fe082aa/3ToP7YyymIgw60aVoz24YW5IKJo1fB9lxcINNingW4eR.mpd?pbs=27eec40dc4504348b5b41b524166e193