search

shaka-project / shaka-player

JavaScript player library / DASH & HLS client / MSE-EME player
Apache License 2.0
7.22k stars 1.34k forks source link

Thumbnails do not show, getImageTracks returns empty list when not supposed to #7639

Open radiantmediaplayer opened 2 days ago

radiantmediaplayer commented 2 days ago

Have you read the FAQ and checked for duplicate open issues? Y

If the problem is related to FairPlay, have you read the tutorial? N

What version of Shaka Player are you using? 4.12.1, 4.11.13, 4.7.15

Can you reproduce the issue with our latest release version? Y

Can you reproduce the issue with the latest code from main? Y

Are you using the demo app or your own custom app? Demo

If custom app, can you reproduce the issue using our demo app? N/A

What browser and OS are you using? Latest Chrome for Windows 11

For embedded devices (smart TVs, etc.), what model and firmware version are you using? N/A

What are the manifest and license server URIs? Do NOT work: https://dash.akamaized.net/akamai/bbb_30fps/bbb_with_4_tiles_thumbnails.mpd https://dash.akamaized.net/akamai/bbb_30fps/bbb_with_tiled_thumbnails_2.mpd https://dash.akamaized.net/akamai/bbb_30fps/bbb_with_multiple_tiled_thumbnails.mpd

Do work: https://dash.akamaized.net/akamai/bbb_30fps/bbb_with_tiled_thumbnails.mpd https://livesim2.dashif.org/livesim2/testpic_2s/Manifest_thumbs.mpd

What configuration are you using? What is the output of player.getNonDefaultConfiguration()? Default from demo page

What did you do? Go to https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;panel=ALL_CONTENT;build=uncompiled and apply "Thumbnails" filter, try to play content and hover seek bar to see Thumbnails. DASH-IF THUMBNAILS - Single adaptation set, 7 tiles at 10x1, each thumb 320x180 > show Thumbnails DASH-IF THUMBNAILS - Single adaptation set, 4 tiles at 10x1, each thumb 205x115 > DO NOT show Thumbnails DASH-IF THUMBNAILS - Single adaptation set, 1 tile at 10x20, each thumb 102x58 > DO NOT show Thumbnails DASH-IF THUMBNAILS - Two adaptation sets with different thumb resolutions > DO NOT show Thumbnails DASH-IF THUMBNAILS - Live stream, Single adaptation set, 1x1 tiles (livesim) > show Thumbnails

What did you expect to happen? Thumbnails should be shown in all cases over the seek bar when hovered.

What actually happened? In version 4.7.15 all Thumbnails are shown and getImageTracks return a valid list. With version 4.11. and 4.12. getImageTracks sometimes return an empty list when Thumbnails should be present. Is it a regression or do I need to do something different?

Are you planning send a PR to fix it? N

avelad commented 2 days ago

The change was introduced at https://github.com/shaka-project/shaka-player/commit/bbefeada6a0abf801213fd806dbbc3901854ab6b

These non-working assets use float durations, which is not what the spec allows.