Closed richardARPANET closed 1 year ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
If tests are not running, could it be because your PR is in draft mode? I think first-time contributors might need approval to run tests in GitHub Actions, but I don't see a button for that, presumably because it's just a draft PR.
Feel free to convert it to "ready", even if it's not completely. :-)
@joeyparrish I just re-enabled the build_and_test.yaml
Github action. Maybe it'll now show you something to approve?
It's working now I think. Not yet "ready" really, will comment again when it is.
Sound good. I saw the approval button, and I clicked it.
@joeyparrish could you approve that Github action again? For some reason it's asking for approve upon every new commit..
Workflow triggered.
I'm a little confused about your change, though. The cloud upload node is still using gsutil to upload to s3:// URLs, right? So why would you not want to check for the Google Cloud SDK?
Ah, I didn't know that was even a feature of gsutil :) Will close this then.
No worries. I see you had done a lot of the work needed to re-enable the test workflow. Would you be willing to put up a PR that focuses on that?
Before:
After:
No error, it runs.