shaka-project / shaka-streamer

A simple config-file based approach to preparing streaming media, based on FFmpeg and Shaka Packager.
https://shaka-project.github.io/shaka-streamer/
Apache License 2.0
198 stars 62 forks source link

fix(errors): Do not check for Google Cloud SDK if using an s3 bucket_url #125

Closed richardARPANET closed 1 year ago

richardARPANET commented 1 year ago

Before:

>> shaka-streamer -i input.yml -p pipeline.yml -c s3://local-media/out/

Fatal error:
  Google Cloud SDK not found! Please install version 212.0.0 or higher of Google Cloud SDK.

After:

No error, it runs.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

joeyparrish commented 1 year ago

If tests are not running, could it be because your PR is in draft mode? I think first-time contributors might need approval to run tests in GitHub Actions, but I don't see a button for that, presumably because it's just a draft PR.

Feel free to convert it to "ready", even if it's not completely. :-)

richardARPANET commented 1 year ago

@joeyparrish I just re-enabled the build_and_test.yaml Github action. Maybe it'll now show you something to approve?

richardARPANET commented 1 year ago

It's working now I think. Not yet "ready" really, will comment again when it is.

joeyparrish commented 1 year ago

Sound good. I saw the approval button, and I clicked it.

richardARPANET commented 1 year ago

@joeyparrish could you approve that Github action again? For some reason it's asking for approve upon every new commit..

joeyparrish commented 1 year ago

Workflow triggered.

I'm a little confused about your change, though. The cloud upload node is still using gsutil to upload to s3:// URLs, right? So why would you not want to check for the Google Cloud SDK?

richardARPANET commented 1 year ago

Ah, I didn't know that was even a feature of gsutil :) Will close this then.

joeyparrish commented 1 year ago

No worries. I see you had done a lot of the work needed to re-enable the test workflow. Would you be willing to put up a PR that focuses on that?