search

shaka-project / shaka-streamer

A simple config-file based approach to preparing streaming media, based on FFmpeg and Shaka Packager.
https://shaka-project.github.io/shaka-streamer/
Apache License 2.0
198 stars 62 forks source link

Add support for HEVC video codec #74

Closed KarlGallagher closed 3 years ago

KarlGallagher commented 3 years ago

Using same FFmpeg parameters as h264 for the most part but letting the encoder choose profile and level automatically. Bitrate settings mirror vp9

tested on macOS 10.15.7 and Ubuntu 20.04 LTS (FFmpeg 4.4)

KarlGallagher commented 3 years ago

Heh sorry about that :)

Extra changes reverted

KarlGallagher commented 3 years ago

@joeyparrish I think with the way the tests are constructed right now (using shaka player to stream the output in a browser instance), any test I add will more than likely fail due to general lack of browser support for this codec

https://caniuse.com/hevc

joeyparrish commented 3 years ago

You're right about that. But I believe I have a way to structure the test so that we can at least prove that encoding succeeded and that the correct codec string appears in the manifest.

joeyparrish commented 3 years ago

I'll go ahead and merge this, then follow-up with a change to add the missing test. I'll link to it here FYI. Thanks!

joeyparrish commented 3 years ago

I've added a test for HEVC and a structure for future codec tests, without depending on browser support for any given codec: https://github.com/google/shaka-streamer/commit/89254b4926894396634e085cff281e7d5f3cc2c2

Thanks again for contributing!