search

shaka-project / static-ffmpeg-binaries

Static binaries of FFmpeg, for multiple OS & CPU combinations, built from source in a GitHub Actions workflow.
https://github.com/joeyparrish/static-ffmpeg-binaries/releases
Apache License 2.0
11 stars 9 forks source link

ci: Use repository variables instead of secrets #34

Closed joeyparrish closed 11 months ago

joeyparrish commented 11 months ago

This new feature of GitHub was introduced in January 2023, and gives us an easy way to configure the repo without abusing the secrets system. Secrets are not available to PR contexts (for good reason), so our secret-based configs also did not work on PRs. By moving to the repo variable system, we solve that problem.

https://github.blog/changelog/2023-01-10-github-actions-support-for-configuration-variables-in-workflows/

joeyparrish commented 11 months ago

I thought I had this figured out, but it's not working yet. The environment variables aren't being inherited by the called workflow. 😢