Simpler Bootswatch instructions

shakacode / bootstrap-loader

Load Bootstrap styles and scripts in your Webpack bundle

MIT License

1.02k stars 486 forks source link

Simpler Bootswatch instructions #96

Closed fdcastel closed 2 years ago

fdcastel commented 8 years ago

I believe the recipe for Incorporating Bootswatch themes could be simplified to:

1) Install Bootswatch

npm install --save bootswatch

2) Add to .bootstraprc:

  "preBootstrapCustomizations": "./node_modules/bootswatch/<THEME>/_variables.scss",
  "appStyles": "./node_modules/bootswatch/<THEME>/_bootswatch.scss"

replacing <THEME> with the name of chosen theme (e.g. superhero).

Doing this way there's no need to create any additional files nor directories.

Could somebody please test this? Do you see any problems doing this way?

Pinging: @larsw

Related: #20

justin808 commented 8 years ago

@fdcastel If you're pretty sure of this, create a PR.

wphampton commented 8 years ago

This seems like it should work, however using both methods (yours proposed above and the current docs with separate bs-theme.scss) I'm seeing the behavior similar to #20 with the superhero there: "No mixin named box-shadow". Using the spacelab theme I get different mixin errors. Any ideas @larsw ?

larsw commented 8 years ago

Hi,

Sorry, I haven't looked into this for a while.

--larsw

Judahmeek commented 8 years ago

@wphampton Do you have a public example repository, by any chance?

wphampton commented 8 years ago

I do not, sorry. I ended up taking a different approach when I could not figure it out. It could have been user error so please don't hold the issue open solely on my one comment above. Thanks!