shakacode / old-react-on-rails-examples

Various example apps for React on Rails, outdated
1 stars 0 forks source link

to_dos > todos, desc > description #10

Closed Judahmeek closed 7 years ago

Judahmeek commented 7 years ago

Modification to schema and rails app per our video conference.


This change is Reviewable

justin808 commented 7 years ago

one big comment! otherwise :lgtm: and :shipit:


Reviewed 23 of 23 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.


todo-app-production/spec/examples.txt, line 3 at r1 (raw file):

example_id                                            | status  | run_time        |
----------------------------------------------------- | ------- | --------------- |
./spec/controllers/to_dos_controller_spec.rb[1:1:1:1] | passed  | 0.00841 seconds |

please .gitignore this file!

and git rm it!


Comments from Reviewable

justin808 commented 7 years ago
:lgtm:

Reviewed 4 of 23 files at r1, 9 of 9 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable