search

shakacode / re-formality

Form validation tool for reason-react
https://re-formality.now.sh
MIT License
244 stars 35 forks source link

Add isValid and isDirty functions to non async forms #40

Closed arnarthor closed 5 years ago

arnarthor commented 6 years ago

This adds an isValid and isDirty function to non async forms. I haven't added this to Async forms since it's a bit more complex and I wanted some feedback on the isDirty function before finishing Async forms as well.

alex35mil commented 6 years ago

It looks like this change will drastically simplify things since the tricky part on each update reduced to figuring out the single value: visibility.

arnarthor commented 6 years ago

Right! That all makes perfect sense 👌 I wasn't sure why you intially wanted Dirty(option(result)) but now it makes sense. Didn't think about other strategies than those in the examples 👍

I'll fix it ASAP

alex35mil commented 6 years ago

@arnarthor Ping, let me know if you need a hand w/ this change.

arnarthor commented 5 years ago

Hey sorry about this dragging so long. I was dragged into another urgent project at work and been pretty swamped last couple of weeks.

I'll try to get to this ASAP, but not sure if it'll be this weekend or the next.

alex35mil commented 5 years ago

@arnarthor np np, thanks for update!

alex35mil commented 5 years ago

Implemented in #41.