Closed Coobaha closed 5 years ago
One thing i am not happy with this approach is js output, it is inlined per functor.
Seems that bucklescript doesn't inline modules when they are coming from the other file
I moved make functors to new files, this eliminates duplicated output (and adds a lot of diff :D) I made potential internal breaking changes (module aliases were moved in files prefixed with __). Maybe worth to add to the changelog
@alexfedoseev ping! :)
@alexfedoseev no worries, renaming done :)
@Coobaha Renaming looks good! And the second point?
ah, sorry i've missed it. My initial version was using functors in the same file. Problem is that it doubles the size of javascript output, Bucklescript inlines same code to Make
and to MakeWithId
Oh, good catch! Then LGTM. Thanks again!
Adds helper functors to provide custom fields comparator to form config
resolves #52