search

shakacode / react-webpack-rails-tutorial

Example of integration of Rails, react, redux, using the react_on_rails gem, webpack, enabling the es7 and jsx transpilers, and node integration. And React Native! Live Demo:
http://www.reactrails.com
MIT License
1.72k stars 384 forks source link

Remove application_static from docs due to Webpacker changes #407

Open justin808 opened 7 years ago

justin808 commented 7 years ago

Per this search:

https://github.com/shakacode/react-webpack-rails-tutorial/search?utf8=%E2%9C%93&q=application_static&type=

This needs cleanup.

rnice01 commented 7 years ago

Hey I'd like to help out with this if I could, seems simple enough.

justin808 commented 7 years ago

@rnice01 Please start on this! I'll mark this taken by you, but you have only a few days to show progress. Get in touch if you want a Slack invite as well. And we need to update the docs for https://github.com/shakacode/react_on_rails.

ramrudra commented 6 years ago

@justin808 I'll pick this up

singhvaibhavram commented 6 years ago

@justin808 I would like to take this.

justin808 commented 6 years ago

@singhvaibhavram Sure. If we can get proper HMR working as well, that would be great.

ramrudra commented 6 years ago

@justin808 @singhvaibhavram PR #446 is for this specific issue.

singhvaibhavram commented 6 years ago

Yup. Will try that too. Give me a day to get me acquainted with the project and then will do that.!!

On Mon, Aug 27, 2018, 12:49 PM Justin Gordon notifications@github.com wrote:

@singhvaibhavram https://github.com/singhvaibhavram Sure. If we can get proper HMR working as well, that would be great.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/shakacode/react-webpack-rails-tutorial/issues/407#issuecomment-416137668, or mute the thread https://github.com/notifications/unsubscribe-auth/AM1RoXClUDp8iOZsskR0SwVsivsnZE44ks5uU518gaJpZM4OZKAN .

singhvaibhavram commented 6 years ago

@ramrudra can you msg me on slack? I have to ask you something regarding the pull request you made. slack email: vaibhavnarayansingh147@gmail.com

singhvaibhavram commented 6 years ago

@justin808 I have messaged you on slack for some doubts.

ramrudra commented 6 years ago

@singhvaibhavram Sure.

@justin808 Could you please send me a slack invite on ramrudra.p@gmail.com