search

shakacode / react_on_rails

Integration of React + Webpack + Rails + rails/webpacker including server-side rendering of React, enabling a better developer experience and faster client performance.
https://www.shakacode.com/react-on-rails/docs/
MIT License
5.11k stars 630 forks source link

Reduce rails dependency #1366

Closed supremebeing7 closed 1 year ago

supremebeing7 commented 3 years ago

It would be nice if this gem could depend only on the gems from rails it needs, rather than the full rails gem. I'm not sure what specific parts are needed without digging, but I'd guess something like railties, actionview, sprockets-rails?

The whole hoopla with mimemagic versions getting yanked and rails activestorage gem depending on it really shined a light on this type of thing.

I'm happy to help in some way, even posting a PR with some changes, though I don't have a ton of time to dig through the internals of this gem.

justin808 commented 3 years ago

@supremebeing7 Sure...PR would be great!