shakacode / react_on_rails

Integration of React + Webpack + Rails + rails/webpacker including server-side rendering of React, enabling a better developer experience and faster client performance.
https://www.shakacode.com/react-on-rails/docs/
MIT License
5.12k stars 631 forks source link

Fix TS types #1582

Closed kotarella1110 closed 1 year ago

kotarella1110 commented 1 year ago

Summary

resolve ReactOnRails.register type errors that occur when strict is true in ts compiler options

fix ServerRenderResult type for react_component_hash

Pull Request checklist

Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by ~.

Other Information

Remove this paragraph and mention any other important and relevant information such as benchmarks.


This change is Reviewable

kotarella1110 commented 1 year ago

CI is down, but it does not appear to be due to this PR change.

Judahmeek commented 1 year ago

@kotarella1110 thank you for your contribution.