shakacode / react_on_rails

Integration of React + Webpack + Rails + rails/webpacker including server-side rendering of React, enabling a better developer experience and faster client performance.
https://www.shakacode.com/react-on-rails/docs/
MIT License
5.12k stars 631 forks source link

build: trigger on main instead of master #1589

Closed ologbonowiwi closed 10 months ago

ologbonowiwi commented 1 year ago

Summary

This PR changes the GH Actions triggers from master to main.

Pull Request checklist

Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by ~.

Other Information

~If any more changes are required, let me know and I can implement it.~ This PR is a kick-off, likely we'll need to open another to make all the changes.


This change is Reviewable

justin808 commented 12 months ago

I'm pretty sure that merging this PR is not the only item, but I could be wrong.

ologbonowiwi commented 12 months ago

I agree with you, @justin808. Honestly, this is more of a first step than a concluded work. As I'm not familiar with the codebase, these were my findings, but I'd be happy to add more stuff to this PR

Judahmeek commented 12 months ago

@justin808 Github documents the changes you'll have to make in the repo settings here: https://github.com/github/renaming

justin808 commented 10 months ago

Did we check the repo for master?

https://github.com/search?q=repo%3Ashakacode%2Freact_on_rails+master&type=code

ologbonowiwi commented 10 months ago

closing this one, but we could track it on #1588.