shakacode / react_on_rails

Integration of React + Webpack + Rails + rails/webpacker including server-side rendering of React, enabling a better developer experience and faster client performance.
https://www.shakacode.com/react-on-rails/docs/
MIT License
5.08k stars 627 forks source link

Restrict css-minimizer-webpack-plugin version in the generator unless using Node v18+ #1598

Closed ahangarha closed 5 months ago

ahangarha commented 5 months ago

Summary

Recently css-minimizer-webpack-plugin released v6.0.0 in which the minimum required Node version is 18.

We install this package in our generator, and we need this PR to ensure our generator doesn't break in an environment with an older Node.

~⚠️ We may need to make a release after this merge.~

~Alternatively, we can bump our Nodejs support to v18 (the current LTS)~

I have change the generator so that it limits the version of this package unless we use Node v18+.

Pull Request checklist

Other Information

-


This change is Reviewable

ahangarha commented 5 months ago

I close this PR regarding this comment. The required change is applied in #1592