Closed vaukalak closed 3 weeks ago
The recent update to react_on_rails
version 14.0.2 includes several important changes. These changes ensure compatibility with Shakapacker v8+, update installation commands to default to yarn classic, and refine the handling of CSS files and version checks. These updates enhance the initialization process and overall experience for users integrating React on Rails with Shakapacker.
File Path | Change Summary |
---|---|
CHANGELOG.md |
Added a fix for project initialization with Shakapacker v8+ by vaukalak in PR 1629. |
docs/getting-started.md |
Updated the installation command to use PACKAGE_JSON_FALLBACK_MANAGER=yarn_classic for Shakapacker. |
lib/generators/react_on_rails/base_generator.rb |
Removed the reference to HelloWorld.module.css in the copy_js_bundle_files method. |
lib/generators/react_on_rails/install_generator.rb |
Changed version check method from using_shakapacker_7? to using_shakapacker_7_or_above? and updated the condition. |
In the land of code where changes flow, React on Rails began to grow. With Shakapacker eight in tow, Installation woes now lay low. A classic yarn, a version check, The bugs are gone, what the heck? Cheers to code, let’s raise a cup, For seamless builds, we level up!
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary
Currently during installation, ror checks against shakapacker 7 version to replace webpacker <=> shakapacker. This doesn't work with sp 8+. This PR fixes the issue.
Pull Request checklist
Add the CHANGELOG entry at the top of the file.
Other Information
Remove this paragraph and mention any other important and relevant information such as benchmarks.
This change is![Reviewable](https://reviewable.io/review_button.svg)
Summary by CodeRabbit
Bug Fixes
Documentation