search

shakacode / reactrails-react-native-client

This repository is for a react-native client to the https://www.reactrails.com/, source at https://github.com/shakacode/react-webpack-rails-tutorial/.
http://www.shakacode.com/work
30 stars 7 forks source link

lints + flow #24

Closed alexeuler closed 7 years ago

alexeuler commented 7 years ago

This change is Reviewable

robwise commented 7 years ago

@robwise are you suggesting that it's better to mark files with jsx with a .jsx extension?

@justin808 Yes that's what we've always been doing. If it has JSX in it, it's a jsx file. If it doesn't, it's a JS file.

justin808 commented 7 years ago

@robwise @alexfedoseev as far as I can tell, the FB examples for react and react-native don't use the jsx extension.

robwise commented 7 years ago

@justin808 We shouldn't deviate from the Airbnb styleguide unless we have a good reason. We would have to change an unbelievably monstrous number of files on F&G if we implement this. It's a good rule IMO anyway.