search

shakacode / sass-resources-loader

SASS resources (e.g. variables, mixins etc.) loader for Webpack. Also works with less, post-css, etc.
MIT License
982 stars 66 forks source link

Package is published with its development-only dependencies #127

Closed thibaudcolas closed 3 years ago

thibaudcolas commented 4 years ago

The package shouldn’t be published with dependencies that are only used for development:

https://github.com/shakacode/sass-resources-loader/blob/ce2700db680bbe100a5f6b0b9edee5c740396dba/package.json#L37-L56

As far as I can see all of @babel/cli, @babel/preset-env, and babel-eslint are only used in development. They should be moved to devDependencies.

justin808 commented 4 years ago

@thibaudcolas could you put this improvement and the one for #126 in a PR?

justin808 commented 3 years ago

@Tomburgs, can you take this one? and one PR incluing #126

justin808 commented 3 years ago

Fixed a long time ago in #128.