shakacode / sass-resources-loader

SASS resources (e.g. variables, mixins etc.) loader for Webpack. Also works with less, post-css, etc.
MIT License
980 stars 66 forks source link

Update async to v3.2.3 #154

Closed ian-hutchinson closed 2 years ago

ian-hutchinson commented 2 years ago

Fix for #153, update async to 3.2.3.

Post update:

yarn install v1.22.18
[1/4] Resolving packages...
success Already up-to-date.
$ yarn run prerelease
yarn run v1.22.18
$ yarn run clean && yarn run build && yarn run test && yarn run lint
$ scripts/clean
$ scripts/build
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
Successfully compiled 9 files with Babel (429ms).
$ jest
 PASS  test/index.test.js
  sass-resources-loader
    resources
      ✓ should parse resource (494 ms)
      ✓ should parse array resources (25 ms)
      ✓ should include resources (38 ms)
      ✓ should throw error when no resources provided (34 ms)
      ✓ should throw error when resources are empty (16 ms)
      ✓ should throw error when resources glob did not resolve any files (11 ms)
      ✓ should throw error when no files were resolved from any resource globs (28 ms)
    hoisting
      ✓ should hoist entry @use imports when option hoistUseStatements is true (34 ms)
      ✓ should not hoist entry @use imports when option hoistUseStatements is false (20 ms)
      ✓ should not hoist entry @use imports when option hoistUseStatements is not passed (40 ms)
      ✓ should work with multiline @use statements (14 ms)
    imports
      ✓ should not rewrite path for imports with ~ (1 ms)
      ✓ should preserve import method (10 ms)
      ✓ should not rewrite the path for built-ins with @use (13 ms)
      ✓ should not rewrite the path for built-ins with @use and double quotes (36 ms)
    getOutput
      ✓ de-duplicates imports from the source when they're present in a resource and `hoiseUseStatements` is enabled (1 ms)

Test Suites: 1 passed, 1 total
Tests:       16 passed, 16 total
Snapshots:   10 passed, 10 total
Time:        1.342 s, estimated 3 s
Ran all test suites.
Jest did not exit one second after the test run has completed.

This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with `--detectOpenHandles` to troubleshoot this issue.
$ scripts/lint
Done in 5.08s.
Done in 5.44s.
justin808 commented 2 years ago

Merged, 2.2.5 released!

Thanks, @ian-hutchinson and @mglombicki-square for making this easy for me!