shakacode / sass-resources-loader

SASS resources (e.g. variables, mixins etc.) loader for Webpack. Also works with less, post-css, etc.
MIT License
980 stars 66 forks source link

Update dependencies #157

Closed LewWadoo closed 1 year ago

LewWadoo commented 1 year ago

This time it doesn't touch eslint dependency despite one of the commit messages.

justin808 commented 1 year ago

@LewWadoo

  1. List how you tested the updates.
  2. Is any new release justified?
LewWadoo commented 1 year ago

@LewWadoo

1. List how you tested the updates.

I relied on yarn run test e.g., jest tests. I used only this one option, so nothing to list.

2. Is any new release justified?

webpack should not be upgraded to a major release, because our documentation states that it supports Webpack 4. It's easier to justify minor and hotfix releases, but all my major upgrades were not justified. I just wanted to see how far I can go without breaking the tests.

justin808 commented 1 year ago

Did CI run? I'm surprised that the code didn't need updates with the eslint changes.

LewWadoo commented 1 year ago

Did CI run? I'm surprised that the code didn't need updates with the eslint changes.

CI tests pass after downgrading eslint, they fail after upgrading it.

justin808 commented 1 year ago

@Judahmeek @LewWadoo what's needed to get CI to run on this branch? #160 is merged.

justin808 commented 1 year ago

And do we need a new release?

LewWadoo commented 1 year ago

And do we need a new release?

I think we do. So we don't need to merge it blindly.

Judahmeek commented 1 year ago

@LewWadoo why not just rebase & force push to this branch instead of creating a new PR?