shakacode / shakapacker

Use Webpack to manage app-like JavaScript modules in Rails
MIT License
400 stars 89 forks source link

Pass in shakapacker config consistently #448

Closed tomdracz closed 3 months ago

tomdracz commented 3 months ago

Summary

Whilst investigating https://github.com/shakacode/shakapacker/issues/408 I couldn't quite replicate the issues but did notice there a few places in the code where we were not respecting SHAKAPACKER_CONFIG env variable. This moves it up one level to main Shakapacker::Instance so it should be used consistently.

There are places like runners where we were using configuration object directly but they were already accounting for path set by env variable.