Closed Judahmeek closed 3 months ago
The recent changes involve removing support for specific environment variables and installation options in Shakapacker
. This includes eliminating @node_modules_bin_path
and SHAKAPACKER_NODE_MODULES_BIN_PATH
, along with altering how the package is installed using npm
and yarn
. The update focuses on streamlining the installation process by ensuring that the JavaScript package is installed in the same directory as the Ruby gem.
Files/Paths | Change Summary |
---|---|
CHANGELOG.md |
Documented the removal of support for certain variables and installation options. |
.../config/environment_variables.rb |
Removed @node_modules_bin_path and SHAKAPACKER_NODE_MODULES_BIN_PATH support. |
.../install/npm.rb |
Updated installation behavior for npm to align with new directory requirements. |
.../install/yarn.rb |
Updated installation behavior for yarn to align with new directory requirements. |
In the code where Shakapacker thrives,
Variables no longer drive,
With paths and bins now gone away,
Simpler installs come to play.
npm and yarn, they lead the way,
Unified gems in one array.
🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
I thought it might be best to be more explicit about this breaking change, as I spent a little time confused over it.
Currently, I only know of two organizations that relied on the removed functionality, but there could be more.
That said, I don't think the removed functionality is necessary since the only reason I can think of for splitting Shakapacker's javascript package & ruby gem between separate directories is CI caching.
Would you agree, @G-Rath?
Summary by CodeRabbit
Shakapacker
.npm
andyarn
.