shakacode / webpacker_lite

Slimmed down version of Webpacker with only the asset helpers optimized for, but not requiring, React on Rails
https://github.com/shakacode/react_on_rails
Other
46 stars 6 forks source link

Updates for v2: Simplified configuration #9

Closed justin808 closed 7 years ago

justin808 commented 7 years ago

This change is Reviewable

justin808 commented 7 years ago

@kaizencodes @robwise @Conturbo please review.

justin808 commented 7 years ago

Hey! big question for @alexfedoseev @robwise @Judahmeek regarding hot reloading and webpacker_lite.

Should webpacker_lite be putting in the value of the hot reloading server host:port as part of the rails helper, or depending on the configuration of that from the manifest.json and requiring the setting of the publicPath in both the webpack output and manifest plugin setup.

My gut tells me that it’s better to keep the webpack manifest simpler so it’s really the mapping of output names to possibly fingerprinted filenames.