Android S support - Githubissues

shakalaca / MagiskOnEmulator

Install Magisk on Official Android Emulator

Apache License 2.0

672 stars 113 forks source link

Closed yujincheng08 closed 3 years ago

yujincheng08 commented 3 years ago

The ramdisk.img format is changed to lz4 in Legacy format (Linux kernel compression).

I tried and successfully patched it. However, Magisk is loaded but caused bootloop.

shakalaca commented 3 years ago

I'll look into it later today :)

shakalaca commented 3 years ago

Please try the latest commit :)

yujincheng08 commented 3 years ago

great! You compiled your own magisk right?

I contacted Jhon Wu and he said he didn't want to support pure 64-bit env. But anyway let me try it out!

yujincheng08 commented 3 years ago

Tested. Works like a charm.

yujincheng08 commented 3 years ago

seems to have some problems: /data/adb/magisk is empty.

KieronQuinn commented 3 years ago

You can fix this manually for the time being:

Extract magisk_emu.zip in the cloned folder
Rename all the files in lib/x86 to remove the "lib" and "so" (they're in that format to avoid being mangled by aapt):
Push the files in lib/x86 to /data/adb/magisk and set them to chmod 755
Push the files in assets to /data/adb/magisk and set them to chmod 755 (I did the files in chromeos too but don't think they're needed)
Cold reboot the emulator

Works!

yujincheng08 commented 3 years ago

Yes I have fixed it manually. But I think it could be done automatically?

BTW, I think you should also submit the code which fixes the manager crash in pure 64 bit env to ur pr in magisk

KieronQuinn commented 3 years ago

Yeah it should be done automatically, I think Magisk Manager would be able to fix itself if it detected root but it doesn't.

shakalaca commented 3 years ago

Hi everyone, this should be done in the latest commit, would you please verify with new VM setup ? :) (I'm using Magisk Canary 22001)

yujincheng08 commented 3 years ago

works! even on M1!