search

shakebugs / shake-ios

Bug and crash reporting SDK for iOS apps.
https://shakebugs.com
Other
30 stars 4 forks source link

App Privacy Manifest #32

Closed Muesly closed 5 months ago

Muesly commented 8 months ago

Apple is soon (Spring 2024) going to require every app to declare App Privacy Manifest files in their app submissions. These declare the privacy use of the app including 3rd Party Libraries like Shake. Are there any plans to add one to this library?

https://developer.apple.com/documentation/bundleresources/privacy_manifest_files

Thanks

mstanic-shake commented 8 months ago

Hi @Muesly, as we are always trying to comply with the requirements of the Apple Store, we'll add privacy manifest for our SDK also.

horsejockey commented 5 months ago

@mstanic-shake any movement on this? This will become a requirement very soon.

mstanic-shake commented 5 months ago

@horsejockey A new version is released: https://docs.shakebugs.com/docs/ios/releases/

sepbehroozi commented 5 months ago

Hello @mstanic-shake

While the latest version of the Shakebugs ios SDK contains the PrivacyInfo.xcprivacy file, it only declares reasons for NSPrivacyAccessedAPICategoryFileTimestamp and NSPrivacyAccessedAPICategoryUserDefaults categories. However when I use this script to scan the RRA usages in our codebase, it says the ShakeBugs SDK uses functions from the Disk space APIs Here's the output:

Used symbols in binary ./Frameworks/Shake.framework/Shake: NSFileSystemFreeSize, NSFileSystemSize, NSURLCreationDateKey, NSUserDefaults, stat

Any chance to consider adding the NSPrivacyAccessedAPICategoryDiskSpace to the privacy manifest?

mstanic-shake commented 4 months ago

@sepbehroozi Did you check this on the latest version? Disk usage was temporarily removed from the latest version as there was no option to select needed permission in xcode

sepbehroozi commented 4 months ago

@sepbehroozi Did you check this on the latest version? Disk usage was temporarily removed from the latest version as there was no option to select needed permission in xcode

Hey @mstanic-shake Yes. We're using version 16.2.4. To make sure I'm not dealing with a cached version, I just checked the XCFramework I downloaded from your Github, still got the same output (NSFileSystemFreeSize, NSFileSystemSize, NSURLCreationDateKey, NSUserDefaults, stat)

mstanic-shake commented 4 months ago

@sepbehroozi Please check 16.2.5 version, we had unused code which was probably detected by script.