search

shaked6540 / YoutubePlaylistDownloader

A tool to download whole playlists, channels or single videos from youtube and also optionally convert them to almost any format you would like
Other
1.25k stars 206 forks source link

Fixed an issue with downloading single video files #239

Closed cristianst85 closed 3 months ago

cristianst85 commented 3 months ago

Updated YoutubeExplode library to the latest version (6.3.13);

Refactored code to use IVideo interface instead of PlaylistVideo when possible; Fixed an issue when downloading single video files (when playlistId is null YoutubeExplode throws 'Invalid YouTube playlist ID or URL').

NOTE: Do not merge this yet as it requires more testing.

Possible fixes for #224, #225, and #238.

shaked6540 commented 3 months ago

Hey, thanks for this. I can merge it, I dont really do too many tests when releasing a new version except for trying to download a playlist, if it works I release it.

Once you remove the WIP from the title I'll merge it, github doesn't let me merge stuff with WIP in the title

cristianst85 commented 3 months ago

I did a force push because I've found that there was additional code that had to be updated.

So short summary. When downloading single videos the playlistId was null and YoutubeExplode was throwing Invalid YouTube playlist ID or URL (not shown in the UI). I think there were some breaking changes introduced to YoutubeExplode library (e.g., deprecated API), but also the few last commits to this project broke few things.

P.S. You can merge this but don't release a new version yet because I have another fix to push for a different issue.

shaked6540 commented 3 months ago

The previous changes were not released yet anyway since they were just code cleanups. I'll wait for your other PR before releasing