shaked6540 / YoutubePlaylistDownloader

A tool to download whole playlists, channels or single videos from youtube and also optionally convert them to almost any format you would like
Apache License 2.0
1.54k stars 243 forks source link

Fixed incorrect index in filenames when converting videos to audio #240

Closed cristianst85 closed 6 months ago

cristianst85 commented 6 months ago

When converting playlist videos to audio the index in the filename was arbitrarily assigned (due to variable reuse in async tasks). This was regardless of the maximum concurrent file conversions setting.

URL used for testing: https://www.youtube.com/watch?v=uFLoZ-gr4PE&list=OLAK5uy_nLwrcZJLKqwkwW1k3GLuic1hA9NUchja8&index=5

YoutubePlaylistDownloader settings to reproduce the issue:

Before the fix (maximum concurrent file conversions was set to 1) https://github.com/shaked6540/YoutubePlaylistDownloader/assets/12585988/fcdf3100-d700-425c-af7c-c65c58e74f60

After the fix (maximum concurrent file conversions was set to 1) https://github.com/shaked6540/YoutubePlaylistDownloader/assets/12585988/1c147f6f-720c-4413-8b57-9ff6272da6a8

After the fix (maximum concurrent file conversions was set to 3) https://github.com/shaked6540/YoutubePlaylistDownloader/assets/12585988/7103ff03-bdba-47b0-9dab-d8add0a1da7c