search

shaked6540 / YoutubePlaylistDownloader

A tool to download whole playlists, channels or single videos from youtube and also optionally convert them to almost any format you would like
Other
1.25k stars 206 forks source link

The "Skip files that already exist" checkbox does not work as expected. #275

Open QuantumRevenant opened 1 month ago

QuantumRevenant commented 1 month ago

If we redownload the requested playlist, it does not ignore the existing files (same name, author, duration, album and even weight). This generates the file with the format:

This fictitious scenario represents that I ran the download 3 times.

  1. The first one downloaded all 3
  2. The second downloaded up to file 2 and stopped manually
  3. The third downloaded up to file 1 and stopped manually

I attach the configurations used (in Spanish)

imagen

shaked6540 commented 1 month ago

Thanks for finding this, I will try to get to it when I have time

toczekmj commented 1 month ago

I could not reproduce that issue on my system.
@shaked6540 have you already resolve that? @QuantumRevenant can you please share your operating system details?

shaked6540 commented 1 month ago

I could not reproduce that issue on my system. @shaked6540 have you already resolve that? @QuantumRevenant can you please share your operating system details?

Nope, I didnt have time to get to it yet

QuantumRevenant commented 1 month ago

@toczekmj I was able to reproduce the error with a different computer (multiple times)! The program was run as administrator The program is with the previously described configurations The playlist was downloaded in queue. The playlist stopped manually downloading at the second song on the first try The playlist stopped manually at the third song on the second try The playlist stopped manually at the second song on the third try

The results in the destination folder are as follows: (The "SongX-1" incidents mentioned above are highlighted in red)

image

I attach the playlist used: https://youtube.com/playlist?list=PLsUhVbl5cUW-wLIMJgnQ_jtwUNcQBdhE_&si=ZpaWyLXLBHQKzt6T

In the following message I will attach the characteristics of this computer and those of the initial one. (It will probably be later) The main thing is that they both use Windows 10 and intel processors

toczekmj commented 1 month ago

Okay, thanks for the in detail informations. I'll give it a shot and try to investigate it more in depth tomorrow.

toczekmj commented 1 month ago

I have found an error in above PR, please let me fix it before you take a look at it.

toczekmj commented 1 month ago

@QuantumRevenant you're welcome to test if it is working for you right now. You can either compile it from my fork source, or use pre-builded files https://github.com/toczekmj/YoutubePlaylistDownloader/releases/tag/Issue (not certainly sure if I can share binaries like this, @shaked6540 correct me if I cannot so Ill remove that link). Also please review #276 when you have time and will to do so.

QuantumRevenant commented 1 month ago

@toczekmj Yes, it works, in English it has no problem, it skips perfectly. In Spanish there is an error "An unexpected error occurred, please contact the administrator.", I suppose the problem is a translation issue. The song also skips, as expected, but you get this error screen 1 time for each song skipped, which is somewhat annoying. Once this fix is ​​officially released, should I raise a new issue or continue on this issue?

imagen

toczekmj commented 1 month ago

I've checked that. It is indeed missing translation. It deservers it's own issue.

Edit: #277