Improve accessibility of actions

shakee93 / vue-toasted

🖖 Responsive Touch Compatible Toast plugin for VueJS 2+

https://shakee93.github.io/vue-toasted/

MIT License

2.21k stars 194 forks source link

Closed davidsandoz closed 3 years ago

davidsandoz commented 4 years ago

The actions are always using the anchor element <a>, regardless whether it is an navigation action or not.

The anchor element should be used only if the action has an href attribute. Otherwise a <button> must be used.

This PR adds this check and also resets the style of the button so that it visually doesn't change.

shakee93 commented 4 years ago

can you please fix this conflict with the latest version. if so i can accept this pull.

thanks

davidsandoz commented 3 years ago

@shakee93 Conflicts have been resolved.

shakee93 commented 3 years ago

Thanks 🙏 Merged !

davidsandoz commented 3 years ago

Thanks @shakee93! Do you have an ETA for the next release?

I know I'm not really in a good position to ask this, looking at how long it took me to finally get to fix those conflicts 😅