search

shakee93 / vue-toasted

🖖 Responsive Touch Compatible Toast plugin for VueJS 2+
https://shakee93.github.io/vue-toasted/
MIT License
2.21k stars 194 forks source link

Externalize animejs and hammerjs for lower bundle size #170

Open therealpecus opened 4 years ago

therealpecus commented 4 years ago

This PR moves animejs and hammerjs (two popular libraries) from dev dependencies to peer dependencies by declaring them as externals in webpack config.

Updates README.md with installation instructions for all environments.

Reason for the PR

It allows VueJS projects to rely on both libraries as single dependencies, without duplicating bundle size. Without this PR, a project that needed either animejs or hammerjs would ship the libraries twice: once for vue-toasted (in the built minified plugin), and once as a project dependency, needlessly wasting download and parse and compile time on the client.

shakee93 commented 4 years ago

will this work even if vue-toasted is included using a <script> tag in plain HTML ?