search

shakemno / sketch-replace-images

A plugin to replace (as in update) existing images by name in a sketch document.
42 stars 8 forks source link

Sketch update seems to have broken plugin #10

Closed joshjohnsonux closed 5 years ago

joshjohnsonux commented 6 years ago

One of the recent updates to Sketch seems to have broken your plugin. Running replace images after a valid path has been set appears to fail silently with images being left unchanged.

Reproduce-able in Sketch 51.3 on MacOS 10.13.6

shakemno commented 6 years ago

Thanks for the heads up. I will take a look as soon as I can.

shakemno commented 6 years ago

I could not reproduce the issue, the plugin works as expected. Could you please provide more details (open Console.app and look for the sketch logs).

shakemno commented 6 years ago

@joshjohnson72 hey, any chance to get more details about the issue? i couldn't find a case to reproduce. any help is appreciated.

joshjohnsonux commented 6 years ago

I'll see if I can take a look and get something to you by the weekend.

On Thu, Sep 27, 2018 at 12:22 AM shakemno notifications@github.com wrote:

@joshjohnson72 https://github.com/joshjohnson72 hey, any chance to get more details about the issue? i couldn't find a case to reproduce. any help is appreciated.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/shakemno/sketch-replace-images/issues/10#issuecomment-424985777, or mute the thread https://github.com/notifications/unsubscribe-auth/AHuuQLGsaFO2ggNnmHpaip3ClH5XT6n0ks5ufHysgaJpZM4Wnybk .

joshjohnsonux commented 6 years ago

Seems to be throwing an exception:

Exception: ObjC method arrayWithObjects: requires 1 argument, but JavaScript passed 3 arguments

(I'm having deja vu, like we've spoken about this exception before when the plugin ceased to work for me.)

On Thu, Sep 27, 2018 at 10:05 AM Josh Johnson joshjohnson72@gmail.com wrote:

I'll see if I can take a look and get something to you by the weekend.

On Thu, Sep 27, 2018 at 12:22 AM shakemno notifications@github.com wrote:

@joshjohnson72 https://github.com/joshjohnson72 hey, any chance to get more details about the issue? i couldn't find a case to reproduce. any help is appreciated.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/shakemno/sketch-replace-images/issues/10#issuecomment-424985777, or mute the thread https://github.com/notifications/unsubscribe-auth/AHuuQLGsaFO2ggNnmHpaip3ClH5XT6n0ks5ufHysgaJpZM4Wnybk .

shakemno commented 6 years ago

My document has 2 artboards and some images each, using Sketch 51.3 (57544) and the lastest plugin version 0.5.1 - I have no issues...

Would be great if you could send me an example project. Or maybe describe your sketch document (pages, images etc) setup and the steps leading to the issue.

Thanks :-)

shakemno commented 5 years ago

Still don't have any issues. Made new version with update dependencies. Would be great if you could let me now if you still have issues. If so, any chance you can provide a test setup e.g. zip with sketch file and images which is not working for you?!

shakemno commented 5 years ago

Closing due to inactivity and not being able to reproduce.