search

shakemno / sketch-replace-images

A plugin to replace (as in update) existing images by name in a sketch document.
42 stars 8 forks source link

Enhancement Request: Persist Image Path #3

Closed joshjohnsonux closed 8 years ago

joshjohnsonux commented 8 years ago

This is a really useful plug-in and truthfully I can't imagine why it's not part of the core product. Nice work! Only usability issue I'm finding is that it's tedious to have to enter the path repeatedly. It would be a nice improvement to persist that information, ideally on a per project basis if possible.

shakemno commented 8 years ago

Thanks again for your input. I just made some changes... Now the default directory is where the sketch-file is located. Though, you can still set a custom path which will then be used until you change it again. I couldn't (yet) find a good way to persist on a per project basis. Hope this works better, let me know what you think.

joshjohnsonux commented 8 years ago

Awesome!!! Will check it out this week. On Jan 24, 2016 11:56 AM, "shakemno" notifications@github.com wrote:

Thanks again for your input. I just made some major changes. Now the default directory is where the sketch-file is located. Though, you can still set a custom path which will then be used until you change it again. I couldn't (yet) find a good way to persist on a per project basis. Hope this works better, let me know what you think.

— Reply to this email directly or view it on GitHub https://github.com/shakemno/sketch-replace-images/issues/3#issuecomment-174335250 .

shakemno commented 8 years ago

I just replaced the manual path input with NSOpenPanel - should be more convenient to use now. Looking forward to your feedback.

joshjohnsonux commented 8 years ago

Seems to be an issue in my environment. When I set the path, I get an error that says:

​

On Mon, Jan 25, 2016 at 1:47 PM, shakemno notifications@github.com wrote:

I just replaced the manual path input with NSOpenPanel - should be more convenient to use now. Looking forward to your feedback.

— Reply to this email directly or view it on GitHub https://github.com/shakemno/sketch-replace-images/issues/3#issuecomment-174680552 .

shakemno commented 8 years ago

Sorry, but i think you forget to paste the error message. It would be really helpful if you could send it. Also, are you using the AppStore version?

shakemno commented 8 years ago

I fixed an issue - please let me know if it works as expected now.

joshjohnsonux commented 8 years ago

Sorry, I had posted it as an image that didn't come through. Error said, "There seems to be an issue with the path. Please make sure you now(sic) what you're doing."

I'm not using the AppStore version of Sketch, so it shouldn't be a sandbox issue, if that helps. I'll check out the new fix today, and let you know.

On Mon, Jan 25, 2016 at 11:04 PM, shakemno notifications@github.com wrote:

Sorry, but i think you forget to paste the error message. It would be really helpful if you could send it. Also, are you using the AppStore version?

— Reply to this email directly or view it on GitHub https://github.com/shakemno/sketch-replace-images/issues/3#issuecomment-174863675 .

joshjohnsonux commented 8 years ago

Just ran a test with the new build and everything seems to be working as expected. Nice work!!!

On Tue, Jan 26, 2016 at 10:12 AM, Josh Johnson joshjohnson72@gmail.com wrote:

Sorry, I had posted it as an image that didn't come through. Error said, "There seems to be an issue with the path. Please make sure you now(sic) what you're doing."

I'm not using the AppStore version of Sketch, so it shouldn't be a sandbox issue, if that helps. I'll check out the new fix today, and let you know.

On Mon, Jan 25, 2016 at 11:04 PM, shakemno notifications@github.com wrote:

Sorry, but i think you forget to paste the error message. It would be really helpful if you could send it. Also, are you using the AppStore version?

— Reply to this email directly or view it on GitHub https://github.com/shakemno/sketch-replace-images/issues/3#issuecomment-174863675 .

shakemno commented 8 years ago

great :-) thanks again for your input and feedback

joshjohnsonux commented 8 years ago

Hi,

Just wanted to give you a heads up, that my recent update from 3.8 to 3.8.1 seems to have broken your plugin. When I run the replace action, I get no notification (good, bad or other) and obviously the replacement isn't happening. The ability to set the directory appears to be working normally, and gives notification feedback as expected.

Thanks, Josh

On Tue, Jan 26, 2016 at 1:06 PM, shakemno notifications@github.com wrote:

Closed #3 https://github.com/shakemno/sketch-replace-images/issues/3.

— Reply to this email directly or view it on GitHub https://github.com/shakemno/sketch-replace-images/issues/3#event-527102920 .

shakemno commented 8 years ago

Hey Josh,

thanks for the heads up - will take a look asap.

Best, Manolis

joshjohnsonux commented 8 years ago

No problem. I'm trying to figure out how to downgrade to 3.8, just to get the plugin function back. It's VERY useful.

On Mon, May 23, 2016 at 12:27 AM, shakemno notifications@github.com wrote:

Hey Josh,

thanks for the heads up - will take a look asap.

Best, Manolis

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/shakemno/sketch-replace-images/issues/3#issuecomment-220905961

shakemno commented 8 years ago

Hey, the issue should be fixed. Could you please let me know if it's also working for you?

joshjohnsonux commented 8 years ago

Just reinstalling from sketch toolbox should do?

On Mon, May 23, 2016 at 10:25 AM, shakemno notifications@github.com wrote:

Hey, the issue should be fixed. Could you please let me know if it's also working for you?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/shakemno/sketch-replace-images/issues/3#issuecomment-221037600

joshjohnsonux commented 8 years ago

Working great! Thanks.

Out of curiousity, what was the issue? Anything I should yell at the Sketch devs over?

On Mon, May 23, 2016 at 10:25 AM, Josh Johnson joshjohnson72@gmail.com wrote:

Just reinstalling from sketch toolbox should do?

On Mon, May 23, 2016 at 10:25 AM, shakemno notifications@github.com wrote:

Hey, the issue should be fixed. Could you please let me know if it's also working for you?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/shakemno/sketch-replace-images/issues/3#issuecomment-221037600

shakemno commented 8 years ago

yes - but hang on a second. my commit doesn't show up in github yet... will let you know when it's up.

shakemno commented 8 years ago

As per the status page, this seems to be an issue at github - i can't see my changes ;-) but great that you can! The issue was a depreciated way of calling the replace method, take a look at the repo for more details.

All the best, Manolis