search

shakeyourbunny / RWMS

RWMS -- RimWorldModSorter, sort your RimWorld mods
GNU General Public License v2.0
43 stars 8 forks source link

update configuration.py to detect steam on other platforms #19

Closed jpc0 closed 5 years ago

jpc0 commented 5 years ago

I have tested this on my systems and it works. Not sure about other systems.

shakeyourbunny commented 5 years ago

Well, I installed yesterday a virtual OSX box looking at the problems, but just launching the locate program for finding the locations is imho not really smart. I took the locations for OSX from the RimWorld wiki, but they don't seem to be really the right ones.

After launching the --dump-configuration there are really some problems (with Steam / RimWorld) in the current build, will fix then.

Additionally, I also restructured the code yesterday, so the patch won't work.

Although, can you do a pull request just for rwms_sort.py, this is neat and I want to credit you for all your efforts.

Thanks!

shakeyourbunny commented 5 years ago

I reread you pull request, it also does some explicit checking if some directories exist.

This check was consciously removed from the configuration module in order to make the configuration file work: https://github.com/shakeyourbunny/RWMS/commit/a3c21aa711c8ffce45c2be8165679e477980ef01

I integrated some of the configuration paths (linux savegame folder position), will be credited though in the next public commit though.

jpc0 commented 5 years ago

No problems man. Not really interested in credit but sent pull request with just the shell script. Just want to see this improved since I use it quite extensively.

On Thu, 16 May 2019 at 23:01, shakeyourbunny notifications@github.com wrote:

I reread you pull request, it also does some explicit checking if some directories exist.

This check was consciously removed from the configuration module in order to make the configuration file work: a3c21aa https://github.com/shakeyourbunny/RWMS/commit/a3c21aa711c8ffce45c2be8165679e477980ef01

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/shakeyourbunny/RWMS/pull/19?email_source=notifications&email_token=AC6PQWDL2CURCLLAO4S6TGDPVXDUBA5CNFSM4HNG4CA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVTBVCY#issuecomment-493230731, or mute the thread https://github.com/notifications/unsubscribe-auth/AC6PQWCA7YD5WGQMY44J7ZDPVXDUBANCNFSM4HNG4CAQ .