shakyShane / browser-sync-spa

Better Single Page App support for BrowserSync
29 stars 15 forks source link

Support connect-history-api-fallback options #8

Closed at0g closed 8 years ago

at0g commented 8 years ago

Hello again,

This PR updates the connect-history-api-fallback dependency to it's 1.x version and provides a history option so that it [history api fallback] can be configured (or removed entirely).

Note that setting { history: false } does not use the history fallback middleware at all, which is useful if the fallback pages are already being provided (such as through a proxy server).

Passing config to the history api fallback will help when:

Not sure if option name history should be something else? webpack-dev-server calls the option historyApiFallback.

Thoughts?

shakyShane commented 8 years ago

lgtm, :+1: thanks!

Can you squash the second commit though please :)

at0g commented 8 years ago

Thanks for the quick response - the second commit is now squashed. Cheers

shakyShane commented 8 years ago

:star: