search

shakyShane / gulp-svg-sprites

Create SVG sprites or compile to <symbols>
MIT License
334 stars 45 forks source link

Configurable parent font size for ems #36

Closed mikestreety closed 9 years ago

mikestreety commented 10 years ago

[Sorry i keep raising issues!]

Would be good if the base font size for ems could be configurable

https://github.com/shakyShane/gulp-svg-sprites/blob/master/index.js#L218

:smile:

shakyShane commented 10 years ago

:+1:

Eworm commented 10 years ago

Couldn't you do this using a custom dustjs template?

mikestreety commented 10 years ago

@Eworm hmm, i struggled to do any maths in the templates and the /10 is hardcoded.

shakyShane commented 10 years ago

@mikestreety don't forget you can always provide your own 'transformData' function and do your own logic before the data hits the templates.

shakyShane commented 10 years ago

^ this will override the internal.

elivz commented 9 years ago

I just submitted pull request #67, implementing this configuration option.

shakyShane commented 9 years ago

everyone thank @elivz for this, landing in next release :)