Fix missing files in remote repo

shalb / cluster.dev

Cloud-native infrastructure templating. Creating cloud installers for SaaS. Replication of complex cloud-native infrastructures.

https://docs.cluster.dev/

GNU Affero General Public License v3.0

401 stars 36 forks source link

Fix missing files in remote repo #34

Closed voatsap closed 4 years ago

voatsap commented 4 years ago

Add COPY to original Dockerfile (direct to master) Move all paths to direct ones "cd /terraform" "cd /kuberentes"

MaxymVlasov commented 4 years ago

COPY files directly to root is bad idea, /bin/ - is linux dir, for instance. Also make many layers - bad too.

Need WORKDIR app/ COPY . ./

+.dockerignore file

And I think good to be not hardcode absolute path to files, but calculate it from ex. env.WORKDIR - it can help shellcheck see crossfile dependecies when developing

MaxymVlasov commented 4 years ago

Improved version exist in #35