search

shaldengeki / monorepo

MIT License
0 stars 0 forks source link

Macro up database migration #284

Closed shaldengeki closed 1 month ago

shaldengeki commented 1 month ago

If you look at the various projects, under api/migrations/BUILD.bazel, a lot of the same stuff is repeated. We could probably macro this all up, either in a standalone macro, or potentially fold this into the API macro.

shaldengeki commented 1 month ago

Hmm, so I don't think the juice is worth the squeeze right now.

Macroing this all up isn't hard. The problem is that we rely on the source-files being checked into git in order to generate new migrations using alembic. We'll need to write some rules (probably) to generate migrations if we want to replace all of this.

shaldengeki commented 1 month ago

I bit the bullet did this in https://github.com/shaldengeki/monorepo/pull/312