codepathreview
commented
10 years ago :+1: excellent work, Shalin! A few notes after checking out the code:
- Great work on packaging the code (consider creating package for fragments)
- Good to see you created an object for Filters
- Good to see JSON deserializing logic in the Image object. (Consider adding null checks)
- Consider using Parcelable over Serializable (benefits) for passing objects
- Good job using the ConnectivityManager to check for network availability and notifying user about failure (consider externalizing it to Utils)
- Good job using the ViewHolder pattern in your adapters.
- Great job implementing SettingsDialog for filters.
- Consider externalizing your Network calls to external "client" class for reusability
- Good to see you added Search using the action bar and correctly implemented sharing
- Good to see integration with TouchImageView
Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
Submission for Google Image Search App. /cc @nesquena @thecodepath From, Shalin Mehta