search

shalinshah1993 / SBSCL

The Systems Biology Simulation Core Library (SBSCL) provides an efficient and exhaustive Java implementation of methods to interpret the content of models encoded in the Systems Biology Markup Language (SBML) and its numerical solution.
https://draeger-lab.github.io/SBSCL/
GNU Lesser General Public License v3.0
0 stars 2 forks source link

Use maven repositories instead of copying jars in project #12

Closed matthiaskoenig closed 6 years ago

matthiaskoenig commented 6 years ago

Where possible use maven repositories for files instead of copying these in the project.

    <dependency>
      <groupId>jfree</groupId>
      <artifactId>jfreechart</artifactId>
      <version>1.0.19</version>
      <scope>system</scope>
      <systemPath>${project.basedir}/lib/jfree/jfreechart/1.0.19/jfreechart-1.0.19.jar</systemPath>
    </dependency>

Should be https://maven-repository.com/artifact/org.jfree/jfreechart/1.0.19

<dependency>
  <groupId>org.jfree</groupId>
  <artifactId>jfreechart</artifactId>
  <version>1.0.19</version>
</dependency>

Also the glpk solver should be probably the following http://glpk-java.sourceforge.net/ instead of 

    <dependency>
      <groupId>nmi</groupId>
      <artifactId>glpksolver</artifactId>
      <version>4.35</version>
      <scope>system</scope>
      <systemPath>${project.basedir}/lib/nmi/glpksolver/4.35/glpkSolver-4.35.jar</systemPath>
    </dependency>
shalinshah1993 commented 6 years ago

I think JFreeChart is already updated! I cannot update maven for glpk since we exactly need the new JAR compiled by Hannes which works with 64-bit windows systems.